Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update editor canvas and block properties #5026

Open
wants to merge 17 commits into
base: feature/25-00-SC-editor-revamp
Choose a base branch
from
Open

feat: update editor canvas and block properties #5026

wants to merge 17 commits into from

Conversation

levi-zustiak
Copy link
Contributor

@levi-zustiak levi-zustiak commented Jan 28, 2025 •
edited
Loading

Description

Changes

  • Updates the editor display the canvas and drawers on specific click events
  • Adds the activeAction variable to EditorProvider. This has three states: Idle, View, and Edit
  • Renames Slider to EditorManager and emoves the slider functionality and replaces with the click actions to display the canvas and drawer

@levi-zustiak levi-zustiak self-assigned this Jan 28, 2025
@linear Linear
Copy link

linear bot commented Jan 28, 2025

ENG-1720 Modal `Canvas` and `Block Properties`

@levi-zustiak levi-zustiak changed the base branch from main to feature/25-00-SC-editor-revamp January 28, 2025 03:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Warnings
⚠️ ❗ Big PR (907 changes)

(change count - 907): Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS against d8204c9

@github-actions github-actions bot temporarily deployed to Preview - arclight January 28, 2025 03:25 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys January 28, 2025 03:26 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys-admin January 28, 2025 03:27 Inactive
@github-actions github-actions bot temporarily deployed to Preview - short-links January 28, 2025 03:27 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects.

Name Status Preview Updated (UTC)
docs ✅ Ready docs preview Thu Jan 30 09:33:03 NZDT 2025

@github-actions github-actions bot temporarily deployed to Preview - videos-admin January 28, 2025 03:27 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects.

Name Status Preview Updated (UTC)
arclight ✅ Ready arclight preview Thu Jan 30 09:33:24 NZDT 2025

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys ✅ Ready journeys preview Fri Jan 31 14:19:26 NZDT 2025

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects.

Name Status Preview Updated (UTC)
short-links ✅ Ready short-links preview Thu Jan 30 09:35:22 NZDT 2025

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready journeys-admin preview Fri Jan 31 14:20:27 NZDT 2025

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects.

Name Status Preview Updated (UTC)
watch ✅ Ready watch preview Fri Jan 31 14:19:56 NZDT 2025

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects.

Name Status Preview Updated (UTC)
videos-admin ✅ Ready videos-admin preview Fri Jan 31 14:19:40 NZDT 2025

@github-actions github-actions bot temporarily deployed to Preview - arclight January 28, 2025 22:45 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys January 28, 2025 22:46 Inactive
@github-actions github-actions bot temporarily deployed to Preview - short-links January 28, 2025 22:46 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys-admin January 28, 2025 22:46 Inactive
@github-actions github-actions bot temporarily deployed to Preview - videos-admin January 28, 2025 22:47 Inactive
@levi-zustiak levi-zustiak force-pushed the levizustiak/eng-1720-modal-canvas-and-block-properties branch from c94beb7 to e29f316 Compare January 29, 2025 18:33
@github-actions github-actions bot temporarily deployed to Preview - journeys January 29, 2025 18:36 Inactive
@github-actions github-actions bot temporarily deployed to Preview - arclight January 29, 2025 18:36 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys-admin January 29, 2025 18:37 Inactive
@levi-zustiak levi-zustiak added this to the 2025 - 00 Cycle milestone Jan 30, 2025
@levi-zustiak levi-zustiak linked an issue Jan 30, 2025 that may be closed by this pull request
Modal Canvas and Block Properties #4872
Open
@github-actions github-actions bot temporarily deployed to Preview - journeys-admin January 30, 2025 22:57 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys January 30, 2025 22:57 Inactive
@github-actions github-actions bot temporarily deployed to Preview - videos-admin January 30, 2025 22:57 Inactive
@levi-zustiak levi-zustiak force-pushed the levizustiak/eng-1720-modal-canvas-and-block-properties branch from 6b96ca2 to d8204c9 Compare January 31, 2025 01:09
@github-actions github-actions bot temporarily deployed to Preview - journeys January 31, 2025 01:15 Inactive
@github-actions github-actions bot temporarily deployed to Preview - videos-admin January 31, 2025 01:15 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys-admin January 31, 2025 01:16 Inactive
@levi-zustiak levi-zustiak marked this pull request as ready for review January 31, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csiyang csiyang csiyang approved these changes

Assignees

@levi-zustiak levi-zustiak

Labels
effort: 2 Feature priority: soon type: feat Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
2025 - 00 Cycle
Development

Successfully merging this pull request may close these issues.

Modal Canvas and Block Properties
2 participants
@levi-zustiak @csiyang