Fix #6237; omp.lua script errors if launching oh-my-posh fails #6238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanDeDobbeleer
force-pushed
the
fix_lua_popen_error
branch
from
05c8a28 to
213d19a
Compare
The omp.lua script was missing some error handling, which caused Lua to abort the script and print errors to the terminal. - error handling is needed when calling `io.popen()`. - error handling is needed when calling `io.popenyield()`. - error handling is needed when calling `os_clock_millis()`. - when the omp.lua prompt filter failed to generate a prompt string, then there was no prompt at all, which was very confusing. Now upon failure it writes a log entry into the clink.log file and generates a simple basic default prompt string plus a note that it failed. resolves JanDeDobbeleer#6237
JanDeDobbeleer
force-pushed
the
fix_lua_popen_error
branch
from
213d19a to
9e9e578
Compare
|
@all-contributors please add @chrisant996 for code This is pure magic 🪄! @holopin-bot @chrisant996 wizard |
|
Congratulations @chrisant996, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm7yij68g85380cjutjitsnjt This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
|
I've put up a pull request to add @chrisant996! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: The omp.lua script was missing some error handling, which caused Lua to abort the script and print errors to the terminal.
io.popen().io.popenyield().os_clock_millis().resolves #6237