Clean up checkstyle warnings #2765
Conversation
tobiasdiez
added
the
status: ready-for-review
There was a problem hiding this comment.
Hi @snisnisniksonah, thank you for your contribution.
Improving the readability of the code is indeed something useful!
While I honor the contribution, I would kindly ask you to change the destination of this PR to JabRef's master branch instead of checkstyle. (unless, of course, you have been in contact with @koppor before)
Furthermore, please execute gradle check to check that your changes don't break our build which seems to be the case:
:checkstyleJmh FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleJmh'.
> Unable to create a Checker: configLocation {/tmp/checkstyle/config/checkstyle/checkstyle.xml},
| private static final Pattern HTML_NEWLINE = Pattern.compile(" ?<br>|<BR>"); | ||
| private static final Pattern REMOVE_HTML = Pattern.compile("<(?!br)(?!BR).*?>"); | ||
| private static final Pattern WHITESPACE_AROUND_NEWLINE = Pattern.compile("(?m)^\\s+|\\v+"); | ||
| private static final Pattern DOUBLE_WHITESPACES = Pattern.compile("[ ]{2,}"); | ||
| private final String htmlText; | ||
|
|
There was a problem hiding this comment.
I don't see why there should be a blank line
Fix all checkstyle warnings and added checkstyle suppression in gen
koppor
removed
the
status: ready-for-review
snisnisniksonah
force-pushed
the
checkstyle
branch
from
2358cfe to
d3dfd46
Compare
…into checkstyle # Conflicts: # src/main/java/org/jabref/gui/entryeditor/FieldExtraComponents.java # src/main/java/org/jabref/preferences/JabRefPreferences.java
LinusDietz
added
the
status: ready-for-review
LinusDietz
changed the title
LinusDietz
removed
the
status: ready-for-review
|
@snisnisniksonah, I have added a [WIP] tag to the title to indicate that this PR is still work in progress. Please remove it when you want feedback for this PR. |
koppor
added
the
status: ready-for-review
snisnisniksonah
changed the title
build.gradle
Outdated
| @@ -390,7 +390,7 @@ task media(type: com.install4j.gradle.Install4jTask, dependsOn: "releaseJar") { | |||
| checkstyle { | |||
| // do not use other packages for checkstyle, excluding gen(erated) sources | |||
| checkstyleMain.source = "src/main/java" | |||
| toolVersion = '6.17' | |||
| toolVersion = '7.6' | |||
There was a problem hiding this comment.
The latest version is already 7.6.1.
koppor
removed
the
status: ready-for-review
|
@snisnisniksonah Could you try to adapt the IntelliJ code style accordingly (https://github.com/JabRef/jabref/tree/master/config)? |
Clean up checkstyle warnings
Add checkstyle suppression for gen