Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine PULL_REQUEST_TEMPLATE.md #12749

Merged
merged 13 commits into from
Mar 16, 2025
Merged

Refine PULL_REQUEST_TEMPLATE.md #12749

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2d54d92
Refine PULL_REQUEST_TEMPLATE.md
koppor Mar 16, 2025
3eeda1f
Refinements
subhramit Mar 16, 2025
d1179d1
Thilo's suggestions
subhramit Mar 16, 2025
c1da0e1
Remove redundant text
subhramit Mar 16, 2025
6dcda16
Refine screenshot check
subhramit Mar 16, 2025
599cd84
Tiny refinement
subhramit Mar 16, 2025
b9a5c33
Unify same information
subhramit Mar 16, 2025
d3d430a
Refine WIP comment
subhramit Mar 16, 2025
f8b8b51
Update .github/PULL_REQUEST_TEMPLATE.md
subhramit Mar 16, 2025
1d05f0d
Update .github/PULL_REQUEST_TEMPLATE.md
subhramit Mar 16, 2025
1ea54a3
refine first few lines
subhramit Mar 16, 2025
c7e8449
one more underscore
subhramit Mar 16, 2025
d6ec0a4
xyz -> numbers
subhramit Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,27 @@
<!-- YOU HAVE TO MODIFY THIS TEXT TO FIT YOUR PR. OTHERWISE, YOUR PR WILL BE CLOSED WITHOUT FURTHER COMMENT. -->

Describe the changes you have made here: what, why, ...
<!-- YOU HAVE TO MODIFY THE TEXT BELOW TO FIT YOUR PR. OTHERWISE, YOUR PR WILL BE CLOSED WITHOUT FURTHER COMMENT. -->

<!-- LINK THE ISSUE WITH THE "Closes" KEYWORD -->
<!-- Example: Closes (link) OR Closes #xyz -->
<!-- Example: Closes (link) OR Closes #12345 -->

Closes _____
Describe the changes you have made here: what, where, why, ...
If your work is not yet complete, please open a draft pull request. In that case, outline your intended next steps. Do you need feedback? Will you continue in parallel? ...

### Mandatory checks

<!--
- Go through the list below. Please don't remove any items.
- [x] done; [ ] not done / not applicable
Go throgh the checklist below. It is mandatory, even for a draft pull request.

Keep ALL the items. Mark them as follows:
[x] done
[ ] not done
[/] not applicable
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[/] is not supported by GitHub:

image

But I find it helpful to separate n/a from not done ^^

-->

- [x] I own the copyright of the code submitted and I licence it under the [MIT license](https://github.com/JabRef/jabref/blob/main/LICENSE)
- [ ] Change in `CHANGELOG.md` described in a way that is understandable for the average user (if change is visible to the user)
- [ ] Tests created for changes (if applicable)
- [ ] Manually tested changed features in running JabRef (always required)
- [ ] Screenshots added in PR description (for UI changes)
- [ ] Screenshots added in PR description (if change is visible to the user)
- [ ] [Checked developer's documentation](https://devdocs.jabref.org/): Is the information available and up to date? If not, I outlined it in this pull request.
- [ ] [Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not, I created an issue at <https://github.com/JabRef/user-documentation/issues> or, even better, I submitted a pull request to the documentation repository.