-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "Add example entry" and "Import existing PDFs" when a library is empty #12741
base: main
Are you sure you want to change the base?
Conversation
-Ensures button is hidden when entries exist but are filtered -Add listeners to track database and table entry changes
-used localization -added styles for button
…e-12662 # Conflicts: # src/main/java/org/jabref/gui/maintable/MainTable.java
-checks if directory exists -triggers search for unlinked files ( if directory exists ) -Shows notification and open library properties ( if directory doesn't exist)
// check if file directories is not empty | ||
List<Path> fileDirectories = database.getFileDirectories(filePreferences); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is trivial and simply restates what the code does without providing additional information about the reasoning or higher-level context.
dialogService.showWarningDialogAndWait( | ||
Localization.lang("File directory is not set or does not exist!"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning message ends with an exclamation mark, which should be avoided in UI messages as per guidelines. Should end with a period instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used Key which was already defined in properties , Should i update ?
@trag-bot didn't find any issues in the code! ✅✨ |
// check if file directories is not empty | ||
List<Path> fileDirectories = database.getFileDirectories(filePreferences); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment is trivial and simply restates what the code does. It should be removed as it doesn't provide additional information about the implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment in the Java code is wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix it .
Closes #12662
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)