Fix PDF relativization test

src/main/java/org/jabref/logic/importer/fileformat/PdfMergeMetadataImporter.java

@@ -186,11 +186,23 @@ private static BibEntry mergeCandidates(Stream<BibEntry> candidates) {
         return entry;
     }
 
+    /**
+     * A modified version of {@link PdfMergeMetadataImporter#importDatabase(Path)}, but it
+     * relativizes the {@code filePath} if there are working directories before parsing it
+     * into {@link PdfMergeMetadataImporter#importDatabase(Path)}
+     * (Otherwise no path modification happens).
+     *
+     * @param filePath    The unrelativized {@code filePath}.
+     */
     public ParserResult importDatabase(Path filePath, BibDatabaseContext context, FilePreferences filePreferences) throws IOException {
         Objects.requireNonNull(context);
         Objects.requireNonNull(filePreferences);
 
-        return importDatabase(filePath);
+        List<Path> directories = context.getFileDirectories(filePreferences);
+
+        filePath = FileUtil.relativize(filePath, directories);
+
+        return importDatabase(filePath, filePreferences);
     }
 
     @Override

src/main/java/org/jabref/logic/importer/fileformat/pdf/PdfImporter.java

@@ -5,6 +5,7 @@
 import java.nio.file.Path;
 import java.util.List;
 
+import org.jabref.logic.FilePreferences;
 import org.jabref.logic.importer.Importer;
 import org.jabref.logic.importer.ParseException;
 import org.jabref.logic.importer.ParserResult;
@@ -61,6 +62,18 @@ public ParserResult importDatabase(Path filePath) {
         }
     }
 
+    public ParserResult importDatabase(Path filePath, FilePreferences filePreferences) {
+        Path readPath = filePreferences.getWorkingDirectory().resolve(filePath);
+
+        try (PDDocument document = new XmpUtilReader().loadWithAutomaticDecryption(readPath)) {
+            return new ParserResult(importDatabase(filePath, document));
+        } catch (EncryptedPdfsNotSupportedException e) {
+            return ParserResult.fromErrorMessage(Localization.lang("Decryption not supported."));
+        } catch (IOException | ParseException exception) {
+            return ParserResult.fromError(exception);
+        }
+    }
+
     @Override
     public StandardFileType getFileType() {
         return StandardFileType.PDF;

src/test/java/org/jabref/logic/importer/fileformat/pdf/PdfMergeMetadataImporterTest.java

@@ -90,16 +90,18 @@ void importWorksAsExpected() throws Exception {
 
     @Test
     void importRelativizesFilePath() throws Exception {
-        // Initialize database and preferences
-        FilePreferences preferences = mock(FilePreferences.class);
-        BibDatabaseContext database = new BibDatabaseContext();
-
-        // Initialize file and working directory
         Path file = Path.of(PdfMergeMetadataImporter.class.getResource("/pdfs/minimal.pdf").toURI());
         Path directory = Path.of(PdfMergeMetadataImporter.class.getResource("/pdfs/").toURI());
-        preferences.setWorkingDirectory(directory);
 
-        List<BibEntry> result = importer.importDatabase(file, database, preferences).getDatabase().getEntries();
+        // If you use a mocked class, and then call `set`ters, they won't work... Thus, we have to create the class manually.
+        FilePreferences filePreferences = new FilePreferences("", "", false, "", "", false, false, Path.of(""), false, Path.of(""), false, false, false);
+        filePreferences.setStoreFilesRelativeToBibFile(true);
+        filePreferences.setWorkingDirectory(directory);
+
+        BibDatabaseContext database = new BibDatabaseContext();
+        database.setDatabasePath(directory.resolve("db.bib"));
+
+        List<BibEntry> result = importer.importDatabase(file, database, filePreferences).getDatabase().getEntries();
 
         BibEntry expected = new BibEntry(StandardEntryType.InProceedings)
                 .withField(StandardField.AUTHOR, "1 ")