Added all person name and date fields to InternalBibtexFields #1097
Conversation
oscargus
commented
Apr 4, 2016
oscargus
commented
- Added all person name and date fields to InternalBibtexFields and changed logic which typically detects "author" and "editor" to detect if the field is a person name list field. All date fields now get a calendar button.
- Moved default ImportInspectorDialog fields to ImportInspectorDialog and removed the argument to the constructor since the default was always used anyway.
- Added support for cleaning up dates of the form "uuuu-M-d", e.g. 2016.4.4.
oscargus
added
[outdated] type: enhancement
component: cleanup-ops
status: ready-for-review
| @@ -480,7 +481,7 @@ public Object getColumnValue(BibEntry entry, int column) { | |||
| } | |||
| else { | |||
| String field = FIELDS[column - PAD]; | |||
| if ("author".equals(field) || "editor".equals(field)) { | |||
| if (InternalBibtexFields.getFieldExtras(field).contains(BibtexSingleFieldProperties.PERSON_NAMES)) { | |||
There was a problem hiding this comment.
I think it would make sense to add a method isPersonName(field) to InternalBibtexFields since this is check occurs quite often.
There was a problem hiding this comment.
I was considering that, but at the same time there may be quite a few different methods of that type provided that one supports all properties. But I agree that the call is quite long considering that there are long class names etc and that this is probably the most frequent call.
|
I moved the field arrays to InternalBibtexFields, renamed BibtexSingleFieldProperties to FieldProperties, made AuthorNameChecker check all field with PERSON_NAMES property, and added support for integer (partial) and gender fields. Screen shot for gender field (which is mocked because of #1101), "Single male name" is now only "Male name" etc.
|
oscargus
force-pushed
the
internalbibtexfields
branch
from
dad8155 to
e5a04aa
Compare
|
Please rebase and merge. |
| @@ -5,11 +5,11 @@ | |||
| public enum BibtexSingleFieldProperties { | |||
There was a problem hiding this comment.
Is this class still in use?
There was a problem hiding this comment.
Yes, that is the new class for this. Now renamed to FieldProperties (it might be that the removal was not done, on my office machine it isn't enough to do git add . to include all changes...).
oscargus
force-pushed
the
internalbibtexfields
branch
from
e5a04aa to
f47544b
Compare
oscargus
force-pushed
the
internalbibtexfields
branch
from
f47544b to
3d9149b
Compare
