Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty library should offer two actions #12662

Open
koppor opened this issue Mar 9, 2025 · 13 comments · May be fixed by #12741
Open

Empty library should offer two actions #12662

koppor opened this issue Mar 9, 2025 · 13 comments · May be fixed by #12741
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) good first issue An issue intended for project-newcomers. Varies in difficulty. 📌 Pinned

Comments

@koppor
Copy link
Member

koppor commented Mar 9, 2025

When starting JabRef, and creating an empty library, there is no content in the entry table:

Image

Task:

  • Create button "Add example entry", which adds the BibEntry shown at https://github.com/jabref/jabref/?tab=readme-ov-file#research-and-education.
  • Create button "Import your existing PDFs", which i) ensures that the library directory exists (*) and ii) trigger "Lookup" > "Search for unlinked files" afterwards. In case there is no library directory, ask the user to configure one: Show a notification that no directory exist and then open the library properties.

Image

Image

Note: This is not about JabRef showing no library at all.

(*) Check if org.jabref.model.database.BibDatabaseContext#getFileDirectories is non-empty

@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Mar 9, 2025
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Mar 9, 2025
@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 9, 2025
Copy link
Contributor

github-actions bot commented Mar 9, 2025

👋 Hey @fabriciopereiradiniz, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 23 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@github-actions github-actions bot removed the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 9, 2025
Copy link
Contributor

github-actions bot commented Mar 9, 2025

👋 Hey @fabriciopereiradiniz, you've been automatically unassigned from this issue due to inactivity.

Note

If you'd like to be re-assigned, just leave another comment or ask a maintainer to assign you again.
If you're still actively working on the issue, let us know by commenting, and we can pin it to prevent automatic unassignment.

@koppor koppor moved this from Free to take to Assigned in Good First Issues Mar 9, 2025
@sanjyot242
Copy link

Hey , I would like to work on this issue !

Copy link
Contributor

github-actions bot commented Mar 9, 2025

👋 Hey @sanjyot242, it looks like you're interested in working on this issue! 🎉

If you'd like to take on this issue, please use the command /assign-me to assign yourself.

@koppor koppor moved this from Assigned to Free to take in Good First Issues Mar 9, 2025
@sanjyot242
Copy link

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 9, 2025
Copy link
Contributor

github-actions bot commented Mar 9, 2025

👋 Hey @sanjyot242, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 23 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@subhramit subhramit moved this from Free to take to Assigned in Good First Issues Mar 11, 2025
@sanjyot242
Copy link

@koppor I have a few questions , Where should the "Add Example Entry" button be placed ? What should be the KeyBinding ?

@koppor
Copy link
Member Author

koppor commented Mar 13, 2025

@koppor I have a few questions , Where should the "Add Example Entry" button be placed ? What should be the KeyBinding ?

  • No key binding
  • Image

Maybe you can see at #12461 how to style etc.

@koppor koppor moved this from Assigned to In Progress in Good First Issues Mar 14, 2025
@sanjyot242
Copy link

Hi @koppor , I am opened a draft pull request to get feedback if i am on the right path .

@koppor
Copy link
Member Author

koppor commented Mar 14, 2025

Hi @koppor , I am opened a draft pull request to get feedback if i am on the right path .

I did not see any screenshot. You really did a UI improvmeent. Please help us in refining our workflows to guide contributors to add a screenshot if they make UI changes. We have it in the check list, but you skipped it.

Ah, I see, you skipped the complete check list

Image

We think, we do not ask for much in this project (no Cloud provider logins, no education course to take from us, etc)...

Please share insights why you ignore the Checklist and the bot comments posted right after you submitted your PR. @sanjyot242

@sanjyot242
Copy link

Hi @koppor, my intention with the draft pull request was to get feedback on whether I’m heading in the right direction (i.e., writing code in the correct place). I will ensure that the checklist and bot comments are addressed moving forward.

@koppor
Copy link
Member Author

koppor commented Mar 14, 2025

@sanjyot242 The most important thing would be the screenshot. I first want to look at the user experience 😅

@sanjyot242
Copy link

@koppor i opened a updated pull request for review, Let me know if you have any feedback or changes .
For writing test (are they required for m changes ? ) could you guide me as to what tests can i add ? Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) good first issue An issue intended for project-newcomers. Varies in difficulty. 📌 Pinned
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants