Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the context menu of linked files working for multipe selected files. #12567

Open
koppor opened this issue Feb 24, 2025 · 11 comments
Open

Have the context menu of linked files working for multipe selected files. #12567

koppor opened this issue Feb 24, 2025 · 11 comments
Assignees
Labels
component: entry-editor component: ui good first issue An issue intended for project-newcomers. Varies in difficulty. 📌 Pinned

Comments

@koppor
Copy link
Member

koppor commented Feb 24, 2025

Currently, the functionality of "Remove link" is working for one file only. That means, deletion of multiple linked files with "Remove link" is not possible.

Image

Task

Rework all entries of the context menu being either disabled for multiple selected files or work with multiple selected files.

Current New Comment
Edit (disabled)
Open file Open file(s) iterate through all selected files and open each
Open folder Open folder(s) collect all folders of all selected files (in a set) and open each
Download file Download file(s)
Rename file to a defined pattern (disabled) Disabled, because there is a dialog chec
Move file to file directory Move file(s) to file directory enabled only if all files are outside the file directory
Copy linked file to folder... Copy linked file(s) to folder... All files are copied to the selected destination folder
Redownload file Redownload file(s) only enabled if at least one file has an online link
Remove link Remove link(s)
Permanently delete local file Permanently delete local file(s)

Note that the localization strings need to be replaced.

Illustration

See #12565 at "Current behavior" how to attach two files to an entry.

Hints

Auto link feature

  1. Start JabRef
  2. Open test-library-with-attached-files.bib contained in src\test\resources\org\jabref\logic\search.
  3. Delete all entries EXCEPT minimal-sentence-case. "Keep file(s)" while deleting!
  4. Select entry minimal-sentence-case
  5. Go to tab "General"
  6. See two files attached
  7. Select both
  8. "Remove link"
  9. Both should be gone (above)
  10. Switch entries
  11. Switch back
  12. See that the two links are up again.

This is OK (!) because the entry editor automatically links files beginning with the citation key

Image

@koppor koppor added component: entry-editor component: ui good first issue An issue intended for project-newcomers. Varies in difficulty. labels Feb 24, 2025
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Feb 24, 2025
@github-project-automation github-project-automation bot moved this to Normal priority in Prioritization Feb 24, 2025
@imCal3b
Copy link

imCal3b commented Feb 28, 2025

Hi, I have a class project where I need to resolve an issue on an open source project. I would like to work on resolving this issue, can I be assigned to it?

@lexph-uvic
Copy link

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 1, 2025
Copy link
Contributor

github-actions bot commented Mar 1, 2025

👋 Hey @lexph-uvic, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 15 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@subhramit
Copy link
Member

@imCal3b You had to use the assign-me action. Are you still interested in working on this? Or have you found another issue?

@koppor koppor moved this from Free to take to Assigned in Good First Issues Mar 2, 2025
@imCal3b
Copy link

imCal3b commented Mar 3, 2025

Hi @subhramit, yes I am interested in this issue. @lexph-uvic is another member of my group that will be working on this with me. I will use the assign command to assign myself to the issue. I will also review through the contribution guidelines. Thanks!

update: lexph-uvic is a part of my group so it is okay that he is assigned to the task! If I can be added as a second assignee that would be great, but not necessary

@imCal3b
Copy link

imCal3b commented Mar 3, 2025

/assign-me

Copy link
Contributor

github-actions bot commented Mar 3, 2025

👋 Hey @imCal3b, this issue is already assigned to @lexph-uvic.

Note

⏳ If the issue isn't closed within ** days**, it will be automatically unassigned.
A maintainer can also add you to the list of assignees or swap you with the current assignee.

@subhramit
Copy link
Member

update: lexph-uvic is a part of my group so it is okay that he is assigned to the task! If I can be added as a second assignee that would be great, but not necessary

Ah, that's fine then.

@github-actions github-actions bot removed the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 18, 2025
Copy link
Contributor

📋 Assignment Update

Hi @lexph-uvic, due to inactivity, you have been unassigned from this issue.

Next steps

If you still want to work on this:

  • Ask a maintainer to assign you again
  • If you're making progress, a maintainer can add the pin label to prevent future automatic unassignment

@lexph-uvic
Copy link

lexph-uvic commented Mar 18, 2025

Hi @koppor

@imCal3b and myself are still working on this issue, would we be able to get it pinned 📌?
If it is an issue with multiple assignees, you may unassign myself and just keep @imCal3b.

Thanks

@subhramit
Copy link
Member

Done

@koppor koppor moved this from Free to take to Assigned in Good First Issues Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: entry-editor component: ui good first issue An issue intended for project-newcomers. Varies in difficulty. 📌 Pinned
Projects
Status: Assigned
Status: Normal priority
Development

No branches or pull requests

4 participants