33 address feedback from cran (#35)

* Update citations #33 * Include missing year in citation #33 * 1.0.1 --> 1.0.2 #33 * Update README #33 --------- Co-authored-by: Santiago Hermo <[email protected]>
JMSLab · Apr 21, 2023 · e430cf5 · e430cf5
1 parent 04691ee
commit e430cf5
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 8 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: eventstudyr
 Title: Estimation and Visualization of Linear Panel Event Studies
-Version: 1.0.1
+Version: 1.0.2
 Authors@R: 
     c(person(given = "Simon",
            family = "Freyaldenhoven",
@@ -35,7 +35,7 @@ Authors@R:
     person(given = "Ryan",
            family = "Kessler",
            role = c("cph")))    
-Description: Estimates linear panel event study models. Plots coefficients following the recommendations in Freyaldenhoven et al. (2021). Includes sup-t bands, testing for key hypotheses, least wiggly path through the Wald region. Allows instrumental variables estimation following Freyaldenhoven et al. (2019).
+Description: Estimates linear panel event study models. Plots coefficients following the recommendations in Freyaldenhoven et al. (2021) <doi:10.3386/w29170>. Includes sup-t bands, testing for key hypotheses, least wiggly path through the Wald region. Allows instrumental variables estimation following Freyaldenhoven et al. (2019) <doi:10.1257/aer.20180609>.
 License: MIT + file LICENSE
 Encoding: UTF-8
 Imports:

diff --git a/README.md b/README.md
@@ -9,7 +9,10 @@ Allows instrumental variables estimation following [Freyaldenhoven et al. (2019)
 ## Installation
 
 ```R
-# Install from GitHub
+# Install from CRAN
+install.packages("eventstudyr")
+
+# Install latest version from GitHub
 install.packages("devtools")
 devtools::install_github("JMSLab/eventstudyr")
 ```

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,3 +1,9 @@
+## Resubmission
+This is a resubmission. In this version I have:
+
+* added DOI to the citations in the Description field
+* replaced calls to citEntry() with bibentry()
+
 ## Test environments
 * local R installation, R 4.0.3
 * ubuntu 16.04 (on travis-ci), R 4.0.3

diff --git a/inst/CITATION b/inst/CITATION
@@ -1,11 +1,9 @@
 citHeader("To cite eventstudyr in publications use:")
 
-citEntry(
-  entry    = "Misc",
+bibentry(
+  bibtype = "Misc",
   title    = "eventstudyr package",
   author   = "Simon Freyaldenhoven, Christian Hansen, Jorge Pérez Pérez, Jesse M. Shapiro, Veli M. Andirin, Richard Calvo, Santiago Hermo, Nathan Schor, Emily Wang",
   url      = "https://github.com/JMSLab/eventstudyr",
-  textVersion = paste(
-
+  year     = 2023
   )
-)