Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update latest version text file manually #716

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

wakingrufus
Copy link
Collaborator

@wakingrufus wakingrufus commented Oct 10, 2023

update latest version text file manually

@JLLeitschuh
Copy link
Owner

Any idea what's up with CI?

@wakingrufus
Copy link
Collaborator Author

Any idea what's up with CI?

The endoflife url for java has updated. I fixed it in this PR, but I think you will need to force merge this PR before the actions will work

@wakingrufus
Copy link
Collaborator Author

my fix DOES apply to the PR, which is nice, but the "build (ubuntu-latest, 8) " check needs to be not required anymore since that java 8 and 11 are both end of life now

fix endoflife.date call to new url
Copy link
Owner

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after CI passes

@JLLeitschuh JLLeitschuh merged commit 431af6b into main Oct 12, 2023
15 checks passed
@JLLeitschuh JLLeitschuh deleted the update-release branch October 12, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants