Simplify the challenge and remove Bootstrap & jQuery dependencies

JDLT-Ltd · Jan 8, 2020 · 94f01cc · 94f01cc
1 parent 4ac21c0
commit 94f01cc
Show file tree

Hide file tree

Showing 6 changed files with 46 additions and 123 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
 # Created by .ignore support plugin (hsz.mobi)
 .idea/
 node_modules/
+yarn.lock
diff --git a/README.md b/README.md
@@ -1,20 +1,9 @@
-# [JDLT](https://jdlt.co.uk) full-stack developer challenge
+# [![JDLT](https://jdlt.co.uk/jdlt_500px_light.png "JDLT")](https://jdlt.co.uk) full-stack developer challenge
 
 We're hoping to see how you approach a challenge and what sort of standards you use in your code so please feel free to be as creative as you like.
 
 The [job spec](https://jdlt.co.uk/join/full-stack-developer) will help you understand what we'd like to see.
 
-## Dependencies
-* NPM / Yarn
-## Instructions
-From the project root folder:
-```
-$ npm install
-```
-OR
-```
-$ yarn
-```
 Then it's over to you!
 
 **Please demonstrate:**
@@ -23,7 +12,7 @@ Then it's over to you!
 * Displaying the returned data in the grid
 * Anything else you'd like to show us
 
-### Sample data
+## Sample data
 
 | Supplier    | Product      | Price (£) |
 | ------------|--------------|-----------|

diff --git a/css/dashboard.css b/css/dashboard.css
diff --git a/index.html b/index.html
@@ -1,68 +1,44 @@
 <!DOCTYPE html>
 <html lang="en">
-<head>
-    <meta charset="utf-8">
-    <meta http-equiv="X-UA-Compatible" content="IE=edge">
-    <meta name="viewport" content="width=device-width, initial-scale=1">
-
-    <title>JDLT Tech Challenge</title>
-
-    <link href="node_modules/bootstrap/dist/css/bootstrap.min.css" rel="stylesheet">
-
-    <link href="css/dashboard.css" rel="stylesheet">
-
-</head>
-
-<body>
-
-<div class="container-fluid">
-    <div class="row">
-        <div class="col-sm-12 col-md-12 main">
-            <h1 class="page-header">Product pricing</h1>
-
-            <form>
-                <div class="row">
-                    <div class="form-group col-md-6">
-                        <label for="selSupplier">Supplier</label>
-                        <select class="form-control" id="selSupplier">
-                            <option>xxxx</option>
-                        </select>
-                    </div>
-                    <div class="form-group col-md-6">
-                        <label for="selProduct">Product</label>
-                        <select class="form-control" id="selProduct">
-                            <option>xxxx</option>
-                        </select>
-                    </div>
-                </div>
-            </form>
-
-            <h2 class="sub-header">Product details</h2>
-            <div class="table-responsive">
-                <table class="table table-striped">
-                    <thead>
-                        <tr>
-                            <th>#</th>
-                            <th>Supplier</th>
-                            <th>Product</th>
-                            <th>Price</th>
-                        </tr>
-                    </thead>
-                    <tbody>
-                        <tr>
-                            <td>x</td>
-                            <td>xxxx</td>
-                            <td>xxxx</td>
-                            <td>xxxx</td>
-                        </tr>
-                    </tbody>
-                </table>
-            </div>
-        </div>
-    </div>
-</div>
-
-<script src="node_modules/jquery/dist/jquery.min.js"></script>
-<script src="node_modules/bootstrap/dist/js/bootstrap.min.js"></script>
-</body>
+  <head>
+    <meta charset="utf-8" />
+    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
+    <meta name="viewport" content="width=device-width, initial-scale=1" />
+
+    <title>JDLT Dev Challenge</title>
+  </head>
+
+  <body>
+    <h1>Product pricing</h1>
+    <form>
+      <label for="selSupplier">Supplier</label>
+      <select id="selSupplier">
+        <option>xxxx</option>
+      </select>
+      <label for="selProduct">Product</label>
+      <select id="selProduct">
+        <option>xxxx</option>
+      </select>
+    </form>
+
+    <h2>Product details</h2>
+    <table>
+      <thead>
+        <tr>
+          <th>#</th>
+          <th>Supplier</th>
+          <th>Product</th>
+          <th>Price</th>
+        </tr>
+      </thead>
+      <tbody>
+        <tr>
+          <td>x</td>
+          <td>xxxx</td>
+          <td>xxxx</td>
+          <td>xxxx</td>
+        </tr>
+      </tbody>
+    </table>
+  </body>
 </html>
diff --git a/package.json b/package.json
@@ -1,11 +1,8 @@
 {
   "name": "dev-challenge",
   "version": "1.0.0",
-  "description": "JDLT developer technical challenge",
+  "description": "JDLT full-stack developer challenge",
   "main": "index.html",
-  "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
-  },
   "repository": {
     "type": "git",
     "url": "git+https://github.com/JDLT-Ltd/dev-challenge.git"
@@ -15,9 +12,5 @@
   "bugs": {
     "url": "https://github.com/JDLT-Ltd/dev-challenge/issues"
   },
-  "homepage": "https://github.com/JDLT-Ltd/dev-challenge#readme",
-  "dependencies": {
-    "bootstrap": "^3.3.7",
-    "jquery": "^3.2.1"
-  }
+  "homepage": "https://github.com/JDLT-Ltd/dev-challenge#readme"
 }
diff --git a/yarn.lock b/yarn.lock