Popover now responds to Control-{N,P,J,K} #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typically typing control and n in a TextView advances to the next line, and control-p moves to the previous line. This commit introduces similar functionality to the script selection Popover. It supports both Emacs-like key chords, C-n and C-p, as well as Vi-like alternatives, C-j and C-k. Similar functionality is offered by Dash and Launchbar.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This week I started using Boop in earnest and as a Dash and Launchbar user I expect Control-{N,J} to advance a selection to the next item, or Control-{P,K} to move the selection in the opposite direction. This pull request implements this behaviour in PopoverViewController.