Update Typings #106
Draft
Update Typings #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakgoyal
commented
Feb 5, 2025
| @@ -104,7 +104,8 @@ export const setupExpressServer = async (expressApp: express.Application): Promi | |||
| const appName = req.params.appName | |||
|
|
|||
| if (appName === 'client' || appName == null) { | |||
| handleClientConnection(appName, req, res, next) | |||
| // DID YOU MEAN && appName !== null ??? | |||
There was a problem hiding this comment.
im a little confused by this check. just want to make sure this was intended or not
sakgoyal
commented
Feb 5, 2025
| if (!mappingProfile[button.key]) { | ||
| mappingProfile[button.key] = {} | ||
| } | ||
| mappingProfile[button.key] ??= {} |
There was a problem hiding this comment.
this still results in an error. ButtonMapping seems to have a type that is not compatible or something. needs review
sakgoyal
commented
Feb 5, 2025
| @@ -43,6 +43,7 @@ export const isValidMappingStructure = async (structure: MappingStructure): Prom | |||
| return false | |||
| } | |||
|
|
|||
| // structure.actions.every ? | |||
There was a problem hiding this comment.
could these be replaced by .every iterators instead of a regular for loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requiresyntax to importRecordtypes instead of manually recreating that everytime