Disable alpine functionality check

Until the node20+ used by github runners works (see actions/runner#801) we can't run a test for alpine compatibility.
IronCoreLabs · Sep 11, 2024 · 3435193 · 3435193
1 parent ae81bda
commit 3435193
Showing 1 changed file with 37 additions and 39 deletions.
diff --git a/.github/workflows/typescript-napi-ci.yaml b/.github/workflows/typescript-napi-ci.yaml
@@ -48,50 +48,48 @@ jobs:
         architecture: ${{ matrix.system.arch }}
     - uses: IronCoreLabs/rust-toolchain@v1
       with:
-        profile: minimal
         toolchain: ${{ matrix.rust_version }}
-        override: true
     - name: Install modules
       run: yarn install --ignore-scripts
     - name: Compile
       run: yarn run compile
     - name: Run tests
       run: yarn run test
 
-  test-docker:
-    runs-on: ${{ matrix.os }}
-    container:
-      image: node:${{ matrix.node_version }}-alpine
-    strategy:
-      matrix:
-        rust_version:
-        - stable
-        - beta
-        node_version:
-        - 16
-        - 18
-        - 20
-        - 21
-        os:
-        - buildjet-2vcpu-ubuntu-2204
-        - buildjet-4vcpu-ubuntu-2204-arm
-      fail-fast: false
-    steps:
-    - run: apk add build-base git python3 wget
-    # https://github.com/actions/runner/issues/801#issuecomment-1374967227
-    - run: |
-        apk add gcompat
-        sed -i "s:ID=alpine:ID=NotpineForGHA:" /etc/os-release
-    - run: echo RUSTFLAGS="-C target-feature=-crt-static" >> "${GITHUB_ENV}"
-    - uses: actions/checkout@v4
-    - uses: IronCoreLabs/rust-toolchain@v1
-      with:
-        profile: minimal
-        toolchain: ${{ matrix.rust_version }}
-        override: true
-    - name: Install modules
-      run: yarn install --ignore-scripts
-    - name: Compile
-      run: yarn run compile
-    - name: Run tests
-      run: yarn run test
+  # broken now that node20 is forced even for checkout@v3, which doesn't work using the # WORKAROUND below any more.
+  # test-docker:
+  #   runs-on: ${{ matrix.os }}
+  #   container:
+  #     image: node:${{ matrix.node_version }}-alpine
+  #   strategy:
+  #     matrix:
+  #       rust_version:
+  #       - stable
+  #       - beta
+  #       node_version:
+  #       - 16
+  #       - 18
+  #       - 20
+  #       - 21
+  #       os:
+  #       - buildjet-2vcpu-ubuntu-2204
+  #       - buildjet-4vcpu-ubuntu-2204-arm
+  #     fail-fast: false
+  #   steps:
+  #   - run: apk add build-base git python3 wget
+  #   # WORKAROUND
+  #   # https://github.com/actions/runner/issues/801#issuecomment-1374967227
+  #   - run: |
+  #       apk add gcompat
+  #       sed -i "s:ID=alpine:ID=NotpineForGHA:" /etc/os-release
+  #   - run: echo RUSTFLAGS="-C target-feature=-crt-static" >> "${GITHUB_ENV}"
+  #   - uses: actions/checkout@v4
+  #   - uses: IronCoreLabs/rust-toolchain@v1
+  #     with:
+  #       toolchain: ${{ matrix.rust_version }}
+  #   - name: Install modules
+  #     run: yarn install --ignore-scripts
+  #   - name: Compile
+  #     run: yarn run compile
+  #   - name: Run tests
+  #     run: yarn run test