-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rmk85 Tedit distinguish public TEDIT.NTHCHARCODE from private \TEDIT.NTH..., fix screen update bug #2091
Open
rmkaplan
wants to merge
4
commits into
master
Choose a base branch
from
rmk85--TEDIT--distinguish-internal-external-interfaces,-fix-screen-update-bug
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tested this change on Linux Mint 22 Cinnamon and couldn't reproduce the bug. |
I can't reproduce the bug on master either, so I'm likely testing it wrong. Here's what I do:
At this point I don't notice any rendering issues on main. |
Here is the bad situation:
The top line in the window is a line in the middle of a paragraph (say it begins with a word "thus") that comes after a preceding line in the paragraph that was broken at a space (which would be the last character on the line if that preceding line were to be displayed). Suppose the last word on that preceding line was the word "and".
Position the caret at the beginning of the first visible line. Type backspace to delete the space.
You should see the top line beginning with "andthus". The bug is that you still see only the original "thus"--the top line doesn't get updated.
… On Apr 1, 2025, at 5:13 AM, Paolo Amoroso ***@***.***> wrote:
pamoroso
left a comment
(Interlisp/medley#2091)
I can't reproduce the bug on master either, so I'm likely testing it wrong. Here's what I do:
open TEdit
type a
press the left arrow key to move the caret at the beginning of the line with a
press Ctrl and middle-select a to delete it
At this point I don't notice any rendering issues on main.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
<#2091 (comment)> <https://github.com/notifications/unsubscribe-auth/AQSTUJKTZAKETCUKNSKPZ6L2XJ7GJAVCNFSM6AAAAAB2F4F7DKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRZGE2TQOBRGM>
pamoroso
left a comment
(Interlisp/medley#2091)
<#2091 (comment)>
I can't reproduce the bug on master either, so I'm likely testing it wrong. Here's what I do:
open TEdit
type a
press the left arrow key to move the caret at the beginning of the line with a
press Ctrl and middle-select a to delete it
At this point I don't notice any rendering issues on main.
—
Reply to this email directly, view it on GitHub <#2091 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJKTZAKETCUKNSKPZ6L2XJ7GJAVCNFSM6AAAAAB2F4F7DKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRZGE2TQOBRGM>.
You are receiving this because you authored the thread.
|
…l-interfaces,-fix-screen-update-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much just an internal cleanup to make the distinction between public and private versions of the NTHCHAR functions. The public versions do more argument coercion, the private versions do the work, and they are gradually being used more often in internal code.
This also fixes a bug in the screen update when the caret is positioned to the left of the first character of the top line of a window, and that character is deleted. That presumably deletes the space at the end of the unseen line above, but the last unseen word was not being moved down to the beginning of the top-line.