Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[F403, F405, F821] Warn on undefined names #274

Open
wants to merge 2 commits into
base: gh/"ansley"/4/base
Choose a base branch
from
Open

[F403, F405, F821] Warn on undefined names #274

wants to merge 2 commits into from

Conversation

ansley
Copy link

@ansley ansley commented Mar 8, 2023 •
edited
Loading

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 8, 2023
This was referenced Mar 8, 2023
Open
Open
Open
Open
Open
Open
amyreese
amyreese reviewed Mar 17, 2023
View reviewed changes
src/fixit/rules/pyflakes/no_undefined_name.py
Comment on lines +100 to +104
def fn():
global b
b = 3

x = b + 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is b defined here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyreese amyreese amyreese left review comments

@zsol zsol Awaiting requested review from zsol zsol is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. lint rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansley @amyreese @facebook-github-bot