Add hostgroup edit feature #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
July 11, 2020 20:27
|
The build fails due to version mismatch: i have go 1.13 and the build uses 1.11. I don't want to just go ahead and change the build version without checking with you first, so what should we do here?? @paultyng |
|
@hsorellana sorry, in the middle of transferring this repo, hopefully the maintainers can respond once we complete the transfer process, I'm not familiar with its inner workings, just tasked with the transfer process. |
|
in the mean time this repo has moved into the icinga org, and we are happy to bump the go version we build with, i even bumped it to 1.14. @hsorellana can you try building again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to edit (for now) the
display_namefield for a HostGroup resource without having to recreate any dependent resource. Plus, it adds a secondTestStepwhich acts as an update scenario. Comments are welcomed!