Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: Split trial.json into diff files #129

Merged
merged 8 commits into from
Mar 18, 2024

Conversation

mickahell
Copy link
Collaborator

@mickahell mickahell commented Jan 20, 2024

Summary

Export circuits and texts from trial json into diff files.
Details about folder organization : #122

Details and comments

  • Reorganize into trial_uuid folders
  • Simply to have any get using the get() function and any save to use the save() function
  • Export circuits
  • Export texts
  • Update unit tests

Closes #122

@mickahell mickahell linked an issue Jan 20, 2024 that may be closed by this pull request
@mickahell mickahell self-assigned this Jan 20, 2024
@mickahell mickahell added enhancement New feature or request help wanted Extra attention is needed labels Jan 20, 2024
@mickahell
Copy link
Collaborator Author

mickahell commented Jan 20, 2024

@IceKhan13 @AnsahMohammad
I'm pretty sure it has a better way to encode and decode external part of trial.json (maybe even adding a ref from trial.json to go read external file so then encoding and decoding can be done only once for all).

@mickahell mickahell marked this pull request as draft January 20, 2024 17:04
@IceKhan13
Copy link
Owner

@mickahell put this PR as ready for review when you are done :)

Thank you! Already looks good :)

@mickahell mickahell marked this pull request as ready for review January 29, 2024 17:25
@mickahell
Copy link
Collaborator Author

@IceKhan13 @AnsahMohammad ready for your review :)

@mickahell mickahell removed the help wanted Extra attention is needed label Feb 21, 2024
Copy link
Owner

@IceKhan13 IceKhan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! 🚀

@mickahell mickahell merged commit 20bdfd6 into main Mar 18, 2024
11 checks passed
@mickahell mickahell deleted the 122-client-split-trialjson-into-different-files branch March 18, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client: Split trial.json into different files
2 participants