feat(ci): add dedicated staticcheck run #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwe
force-pushed
the
dnwe/staticcheck
branch
from
9f3b31a to
d231a23
Compare
A number of these are for long-deprecated and now removed linters and no longer validate against the config schema so remove them here. Add hint for yaml-language-server to point at the jsonschema to validate against. Signed-off-by: Dominic Evans <[email protected]>
As we've noted that a standlone run of staticcheck can find different issues compared with running it from golangci-lint, add a standalone run to github actions and remove it from the golangci-lint config Signed-off-by: Dominic Evans <[email protected]>
error strings should not be capitalized (ST1005) Signed-off-by: Dominic Evans <[email protected]>
Switch golangci-lint nolint:unused to staticcheck lint:ignore style Signed-off-by: Dominic Evans <[email protected]>
dnwe
force-pushed
the
dnwe/staticcheck
branch
from
d231a23 to
b3aef99
Compare
hindessm
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we've noted that a standlone run of staticcheck can find different
issues compared with running it from golangci-lint, add a standalone run
to github actions and remove it from the golangci-lint config