fix(ci): patch zookeeper client to 3.5.9 on older Kafka #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having purged the caches and re-built the FV images, it is evident that the 3.4.13 zookeeper client is incompatible with Java 17 (see ZOOKEEPER-3779). Rather than use different Java versions for those, just quietly bump the bundled zookeeper client to 3.5.9 (as used in Kafka 2.6) which is API compatible and resolves the issue with Java 17 Signed-off-by: Dominic Evans <[email protected]>
Using container_name in the docker-compose.yml gives us both a static hostname (as the `hostname` field gave us) and avoids the `sarama` prefix and `-1` suffix on the docker container names too Signed-off-by: Dominic Evans <[email protected]>
dnwe
added
the
ignore-for-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having purged the caches and re-built the FV images, it is evident that the 3.4.13 zookeeper client is incompatible with Java 17 (see ZOOKEEPER-3779). Rather than use different Java versions for those, just quietly bump the bundled zookeeper client to 3.5.9 (as used in Kafka 2.6) which is API compatible and resolves the issue with Java 17