New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ids function reusing smaller ids to construct large ones #10

Closed

DzyubSpirit wants to merge 1 commit into HowProgrammingWorks:master from DzyubSpirit:cash

DzyubSpirit commented Jan 16, 2020

Here I use cache of smaller strings, not sure whether it's actually improve the performance

DzyubSpirit requested a review from tshemsedinov

January 16, 2020 05:25

DzyubSpirit force-pushed the cash branch from 20f1ecd to e1e84b1 Compare

January 16, 2020 05:59


          Improve ids function reusing smaller ids to construct large ones

a13d14e

Fixes: HowProgrammingWorks#5

DzyubSpirit force-pushed the cash branch from e1e84b1 to a13d14e Compare

January 16, 2020 06:03

Author

DzyubSpirit commented Jan 16, 2020

It works ~40% faster with caching when test uses ids up to 45 symbols length.
https://jsperf.com/ids-non-cache-vs-cache

DzyubSpirit closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet