-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iota 0.8.1-rc (new formula) #204325
base: master
Are you sure you want to change the base?
iota 0.8.1-rc (new formula) #204325
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
|
Formula/i/iota.rb
Outdated
class Iota < Formula | ||
desc "Bringing the real world to Web3 with a scalable, decentralized and programmable DLT infrastructure" | ||
homepage "https://www.iota.org" | ||
url "https://github.com/iotaledger/iota/archive/refs/tags/v0.8.1-rc.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to ship release candidates, from the requirements page:
be stable (e.g. not declared “unstable” or “beta” by upstream)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sean, in this case RC is about our deployment which goes from Devnet (alpha/beta, unstable) to Testnet (rc, stable) to Mainnet (stable). RC is a finished and stable release but just not yet deployed on our Mainnet.
This is very similar to the sui
formula but they have opted for a testnet-
suffix https://github.com/Homebrew/homebrew-core/blob/master/Formula/s/sui.rb#L4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That one shouldn't ship testing level software either, we might want to disable that one.
Formula/i/iota.rb
Outdated
depends_on "cmake" => :build | ||
depends_on "libpq" => :build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is it vendoring that it needs these things?
2c3c755
to
d868677
Compare
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?This is the CLI for the the IOTA Testnet.
brew audit --new <formula>
is failing withError: These formulae are not in any locally installed taps!
Am I supposed to install my forked repository as tap? But then the formula is not on the
master
branch so it still wouldn't find it?