Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyperkit: deprecate #173862

Merged
merged 1 commit into from
Jun 6, 2024
Merged

hyperkit: deprecate #173862

merged 1 commit into from
Jun 6, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jun 6, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

followup #172795

failed build log, https://github.com/Homebrew/homebrew-core/actions/runs/9395167391

  ==> expect test_hyperkit.exp
  spawn /usr/local/Cellar/hyperkit/0.20210107_1/bin/hyperkit -A -m 512M -s 0:0,hostbridge -s 31,lpc -l com1,stdio -f kexec,./vmlinuz,./initrd.gz,earlyprintk=serial console=ttyS0
  
  Using fd 8 for I/O notifications
  
  send: spawn id exp6 not open
      while executing
  "send "sudo halt\r\n""
      (file "test_hyperkit.exp" line 17)

Signed-off-by: Rui Chen <[email protected]>
@github-actions github-actions bot added ocaml OCaml use is a significant feature of the PR or issue formula deprecated Formula deprecated no ARM bottle Formula has no ARM bottle macos-only Formula depends on macOS labels Jun 6, 2024
@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jun 6, 2024
@chenrui333 chenrui333 enabled auto-merge June 6, 2024 16:05
@chenrui333 chenrui333 added this pull request to the merge queue Jun 6, 2024
Merged via the queue into master with commit d7eca87 Jun 6, 2024
16 checks passed
@chenrui333 chenrui333 deleted the hyperkit-deprecate branch June 6, 2024 20:08
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated macos-only Formula depends on macOS no ARM bottle Formula has no ARM bottle ocaml OCaml use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants