Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klee: resource tabulate and update build #167910

Merged
merged 2 commits into from
Apr 3, 2024
Merged

klee: resource tabulate and update build #167910

merged 2 commits into from
Apr 3, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Apr 3, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Splitting out some of changes from #164859 as there is some issue in updating where x86_64 is freezing at run.

@cho-m cho-m added homepage python-vendoring Part of the Python resource vendoring project labels Apr 3, 2024
@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Apr 3, 2024
@cho-m cho-m removed the python-vendoring Part of the Python resource vendoring project label Apr 3, 2024
@cho-m cho-m changed the title klee: vendor python resources and update build klee: resource tabulate and update build Apr 3, 2024
Comment on lines +46 to +49
resource "tabulate" do
url "https://files.pythonhosted.org/packages/ec/fe/802052aecb21e3797b8f7902564ab6ea0d60ff8ca23952079064155d1ae1/tabulate-0.9.0.tar.gz"
sha256 "0095b12bf5966de529c0feb1fa08671671b3368eec77d7ef7ab114be2c068b3c"
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabulate has a CLI tool, so we don't need to get rid of it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our decision for CLI tools of PyPI-distributed Python packages are they need to be installed as virtualenvs (falling under terms of https://docs.brew.sh/Python-for-Formula-Authors#installing-applications).

Exposing libraries in HOMEBREW_PREFIX/lib would need to meet the new stricter exceptions (which we should audit, e.g. Homebrew/brew#16663)

Copy link
Contributor

github-actions bot commented Apr 3, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 3, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 3, 2024
Merged via the queue into master with commit 64bb9d5 Apr 3, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the klee-updates branch April 3, 2024 20:33
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. homepage outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants