Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-matplotlib: remove redundant resource blocks #166613

Closed
wants to merge 1 commit into from

Conversation

unitof
Copy link
Contributor

@unitof unitof commented Mar 19, 2024

Prefer with corresponding Homebrew formulae
See https://github.com/orgs/Homebrew/discussions/5211\#discussioncomment-8837868

Will see if this builds & passes tests—in my experience depends_on does not always behave the same behavior as resource blocks, even when they resolve to same PyPI version & download URL.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Mar 19, 2024
@branchvincent
Copy link
Member

Thanks for the pr and sorry for the lack of response, we are actually backtracking a bit and removing most python formulae in favor of resource blocks. More context is in #157500 and https://docs.brew.sh/Python-for-Formula-Authors#libraries. If you'd like to help, #167905 is tracking the remaing work

Closing as #166055 already fixed matplotlib

@github-actions github-actions bot added the outdated PR was locked due to age label May 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants