Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-jinja: remove #165495

Merged
merged 1 commit into from
Mar 8, 2024
Merged

python-jinja: remove #165495

merged 1 commit into from
Mar 8, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 8, 2024

==> Analytics
install: 8,152 (30 days), 45,306 (90 days), 58,716 (365 days)
install-on-request: 103 (30 days), 430 (90 days), 499 (365 days)
build-error: 0 (30 days)

Signed-off-by: Michael Cho <[email protected]>
@cho-m cho-m added python Python use is a significant feature of the PR or issue CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. python-vendoring Part of the Python resource vendoring project labels Mar 8, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request and removed python Python use is a significant feature of the PR or issue labels Mar 8, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Mar 8, 2024
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Mar 8, 2024
Merged via the queue into master with commit dfb41a1 Mar 8, 2024
17 checks passed
@chenrui333 chenrui333 deleted the python-jinja-remove branch March 8, 2024 14:38
@rbalint
Copy link
Contributor

rbalint commented Mar 8, 2024

Hi @chenrui333, this is a build dependency of Firebuild: https://github.com/firebuild/firebuild/blob/0c076a4d8fc7a5dc3add89993f80343867cb8381/Brewfile#L8
Any chance of adding it back?

@rbalint
Copy link
Contributor

rbalint commented Mar 8, 2024

Or should I switch back to using jinja2-cli? Will that formula stay?

rbalint added a commit to rbalint/firebuild that referenced this pull request Mar 8, 2024
rbalint added a commit to rbalint/firebuild that referenced this pull request Mar 8, 2024
rbalint added a commit to rbalint/firebuild that referenced this pull request Mar 8, 2024
@cho-m
Copy link
Member Author

cho-m commented Mar 8, 2024

Any chance of adding it back?

python-jinja does not meet our requirements to remain in homebrew-core

Ref: https://docs.brew.sh/Python-for-Formula-Authors#libraries
Ref: Homebrew/brew#16662


Or should I switch back to using jinja2-cli? Will that formula stay?

jinja2-cli will probably remain as an app/executable.

Ref: https://docs.brew.sh/Python-for-Formula-Authors#applications

@rbalint
Copy link
Contributor

rbalint commented Mar 8, 2024

@cho-m OK, thanks!

rbalint added a commit to firebuild/firebuild that referenced this pull request Mar 8, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age python-vendoring Part of the Python resource vendoring project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants