Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finalshell: fix url and livecheck #185948

Merged
merged 1 commit into from
Sep 19, 2024
Merged

finalshell: fix url and livecheck #185948

merged 1 commit into from
Sep 19, 2024

Conversation

khipp
Copy link
Member

@khipp khipp commented Sep 19, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Closes #185942.

@khipp khipp added the livecheck Issues or PRs related to livecheck label Sep 19, 2024
@bevanjkay bevanjkay merged commit b7d5629 into master Sep 19, 2024
8 checks passed
@bevanjkay bevanjkay deleted the update-finalshell branch September 19, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

finalshell download url is error
2 participants