Update teamviewer from 15.26.4 to 15.26.5 #118326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrui333
previously approved these changes
Jan 30, 2022
6 tasks
miccal
added
awaiting maintainer feedback
carlocab
previously approved these changes
Feb 2, 2022
|
I am not sure how we could that -- can we somehow make it so the CI tests are not run on 10.15 and only run on 11.0? |
|
A really dirty hack might be to do this instead: diff --git a/Casks/teamviewer.rb b/Casks/teamviewer.rb
index 63adb4d948..2c048092bb 100644
--- a/Casks/teamviewer.rb
+++ b/Casks/teamviewer.rb
@@ -23,7 +23,11 @@ cask "teamviewer" do
auto_updates true
conflicts_with cask: "teamviewer-host"
- depends_on macos: ">= :el_capitan"
+ if MacOS.version == :catalina
+ depends_on macos: ">= :big_sur"
+ else
+ depends_on macos: ">= :el_capitan"
+ end
if MacOS.version <= :high_sierra
pkg "Install TeamViewer.pkg"Might still fail CI though. Otherwise we can probably modify our runner-selection script, but I'd like to keep any hacks out of there ideally. |
|
@carlocab how about this? |
carlocab
approved these changes
Feb 2, 2022
Comment on lines
+30
to
+33
| elsif MacOS.version == :catalina | ||
| # This Cask should be installed and uninstalled manually on Catalina. | ||
| # See https://github.com/Homebrew/homebrew-cask/issues/76829 | ||
| installer manual: "Install TeamViewer.app/Contents/Resources/Install TeamViewer.pkg" |
miccal
removed
the
awaiting maintainer feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created with
brew bump-cask-pr.