Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zap stanzas for several casks #100217

Merged
merged 6 commits into from
Feb 22, 2021
Merged

Conversation

muneebmahmed
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask {{cask_file}} worked successfully.
  • brew install --cask {{cask_file}} worked successfully.
  • brew uninstall --cask {{cask_file}} worked successfully.

Adds zap stanzas for several casks in #88469:

  • amazon-workspaces
  • background-music
  • edex-ui
  • parsec
  • pennywise
  • vanilla

Note that most of these casks except for vanilla don't have a desc stanza, so brew audit --cask gives a warning. I was unsure if it was necessary, since they didn't have these stanzas to begin with.

@vitorgalvao vitorgalvao merged commit 84499a3 into Homebrew:master Feb 22, 2021
@muneebmahmed muneebmahmed deleted the add-zaps branch February 22, 2021 09:09
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants