Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance description of working with private packages #237

Merged
merged 14 commits into from
Dec 19, 2024

Conversation

timholy
Copy link
Member

@timholy timholy commented Dec 18, 2024

  • expand on the different roles of different SSH keys
  • describe both packages registered with HolyLabRegistry as well as unregistered private packages
  • remove last vestiges of Travis (update description of PkgTemplates)
  • default to hosting on HolyLab rather than in personal accounts
  • fix formatting

@timholy timholy requested a review from kdw503 December 18, 2024 21:38
@timholy
Copy link
Member Author

timholy commented Dec 18, 2024

There are a lot of tricky whitespace changes, but that makes it harder to focus on the content. It's recommended to review this by clicking on Files changed -> gears icon -> check Hide whitespace -> click Apply and reload

Copy link
Member

@kdw503 kdw503 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer than before.
Thank you.

@kdw503 kdw503 merged commit dcd318d into master Dec 19, 2024
1 check passed
@timholy timholy deleted the teh/private_package branch December 19, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants