Lord Knight skill rebalance - 2018 patch/renewal #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilherme-gm
changed the title
guilherme-gm
force-pushed
the
rebalance-lk
branch
2 times, most recently
from
447e81f to
509ddef
Compare
no reason to FALLTHROUGH + if a lot of code just to save one line of code
- Changed variable cast time*
- Before: 150/250/350/450/500
- After: 250ms in all skill levels
- Changed fixed cast time*
- Before: 150/250/350/450/500
- After: 300ms in all skill levels
- Changed global delay
- Before: 1200/1400/1600/1800/2000
- After: 1sec in all skill levels
- Changed damage formula
- BaseATK increased by 50%
- Old: 150/200/250/300/350
- New: 200/250/300/350/400
- Size modifier changed
- Small: 125% -> 130%
- Medium: 100% -> 115%
- Large: 75% -> 100%
- Now deals more damage depending on user's base level
Note 1: Cast time update is a somewhat a guess.
Patch notes (iRO / kRO)
"variable cast time reduced from 0.5s to 0.25s at level 5"
iRO wiki and bRO wiki says "variable cast time is 0.25s on all skill levels"
we are following wikis here.
Note 2: Just like cast time, fixed cast time is also somewhat a guess.
Patch notes (iRO / kRO)
"Fixed casting time reduced to 0.3 second (previously 0.5 seconds) starting at Level 5"
While iRO wiki and bRO wiki says "0.3 seconds in all skills levels"
we are following wikis here.
From 1st/2nd/Transclass rebalance (2018.11.28)
Co-authored-by: Guilherme G. M. <[email protected]>
- Changed damage bonus formula - Old: SkillLv x 20 - New: BaseLv x (SkillLv + 3) From 1st/2nd/Transclass rebalance (2018.10)
- ATK Bonus changed - Old: (SkillLv x 5) % flat - New: (5 + SkillLv x 2) % ATK % - Def reduction % changed - Old: (SkillLv x 5) % - New: (5 + SkillLv x 2) % - Duration changed to 60s at all skill levels - The effect no longer gets removed when changing/removing weapon From 1st/2nd/Transclass rebalance (2018.10)
it should increase the ration by 5 for each STR point, not 1 From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
guilherme-gm
force-pushed
the
rebalance-lk
branch
from
509ddef to
9bb00b5
Compare
MishimaHaruna
approved these changes
Nov 30, 2024
MishimaHaruna
added a commit
that referenced
this pull request
Dec 1, 2024
Signed-off-by: Haru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
This PR introduces the rebalance of Lord Knight job skills. This change affects Renewal-only.
On official servers this came along with rebalances of 1st, 2nd jobs and transclass too. I am working in additional PRs for the remaining transclasses, being in separate PRs in order to keep those PRs in a reasonable size.
Most credits for this PR goes to @gbasso666, I built it over their changes on #3200, breaking into smaller commits and focusing only on Lord Knight skills. Commits in this PR that has their name, are the ones where most of the changes were picked from #3200.
Some changes of #3200 seems related to a future patch (e.g. SP cost of Concentration in 2018 was still in the old values), those were discarded, since the focus of this PR is on 2018 changes.
I can't say everything is 100% accurate because there are discrepancies between different sources, and I could not test everything in kRO, but should be quite close.
I won't list all the rebalance changes in the PR description, but it may be checked in each commit text. Also, the commits are in the same order as they appear in the references below.
As an extra, there is a fix for Knight's KN_BRANDISHSPEAR (Brandish Spear), based on the changes of #3200 I noticed my previous PR was missing some damage in the STR bonus.
Affected skills
References:
Issues addressed:
Part of #2735