-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make basic Socket writing, so Http could work #187
base: master
Are you sure you want to change the base?
Conversation
HTTPS still not working as we must implement/override Http customRequest
Could this get merged? |
You mean to ask my permission? Of course, I made a pull request a while ago. I have already a few additional commits (Process, SQLite) once things get moving. With web-workers, we could already remove the dependency on deasync too. This is what I wonder in my head If something is wrong with the commit what? |
Ahh, no, i was bumping for the maintainers. This has kind of been sitting idle for a lil while and it works fine. I was about to do the same work myself before checking to see if someone else had done the work |
Hi @neimanpinchas, thanks for your PR! |
@kLabz It enables http support on the nodejs target var http = new Http('https://google.com');
http.onData = (resp) -> {
trace(resp);
}
http.request(); Currently does not work, with this pr the above code would now work |
I do not see a test folder, can you give a hint on where the test are added? Thanks |
HTTPS still not working but that would work
|
HTTPS still not working as we must implement/override Http customRequest