Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make basic Socket writing, so Http could work #187

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

neimanpinchas
Copy link

HTTPS still not working as we must implement/override Http customRequest

HTTPS still not working as we must implement/override Http customRequest
@Jarrio
Copy link

Jarrio commented Feb 25, 2023

Could this get merged?

@neimanpinchas
Copy link
Author

You mean to ask my permission? Of course, I made a pull request a while ago.

I have already a few additional commits (Process, SQLite) once things get moving.

With web-workers, we could already remove the dependency on deasync too.

This is what I wonder in my head

If something is wrong with the commit what?
If the maintainers have no time for it, maybe enable us to maintain?
If the maintainers have no purpose for it, I do have!
Did I miss somethings, what?

@Jarrio
Copy link

Jarrio commented Feb 27, 2023

Ahh, no, i was bumping for the maintainers. This has kind of been sitting idle for a lil while and it works fine. I was about to do the same work myself before checking to see if someone else had done the work

@kLabz
Copy link
Contributor

kLabz commented Mar 27, 2023

Hi @neimanpinchas, thanks for your PR!
Do you have an example usage of this so I could add corresponding tests, and check that everything is working properly? (tests happen in a different repo, it's understandable that they wouldn't be handled by contributors here)

@Jarrio
Copy link

Jarrio commented Mar 27, 2023

@kLabz It enables http support on the nodejs target

var http = new Http('https://google.com');
http.onData = (resp) -> {
   trace(resp);
}
http.request();

Currently does not work, with this pr the above code would now work

@neimanpinchas
Copy link
Author

I do not see a test folder, can you give a hint on where the test are added?

Thanks

@neimanpinchas
Copy link
Author

HTTPS still not working but that would work

var http = new Http('http://example.com');
http.onData = (resp) -> {
   trace(resp);
}
http.request();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants