Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace nekotools server with npx http-server for local development #318

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

ninjamuffin99
Copy link
Contributor

dox already assumes you have nodejs of some sort setup (requires lix), so this PR changes the nekotools server command that loads up the webserver for development purposes, and instead uses http-server (which is what lime uses, albeit as an included binary rather than npx)

Ideally it can be a more haxe solution (snake-server would be a good candidate, but it wasn't playing too nicely with lix for me...)

This PR should allow a bit easier development, as well as less reliance on neko

@Simn
Copy link
Member

Simn commented Sep 26, 2024

I generally agree with removing neko dependencies, but I'm not sure if replacing it with a nodejs dependency is that much progress... But then again I don't think I even noticed that Make.hx file before so if this makes your life easier I see no reason not to merge this!

@Simn Simn merged commit e92caad into HaxeFoundation:master Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants