Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrades CI workflow actions #458

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Jul 1, 2024

Acceptance Criteria

  • Fixes warnings about the CI workflow actions to use NodeJS 20
  • Forces an error on CI if CodeCov fails, to improve our understanding of its errors

Notes

The upload-artifact and gh-docker-logs actions will be upgraded in a future moment, as they have breaking changes that will need more attention to adapt to.

The intermittent errors we're having of not finding the secret token on CodeCov seems to have been fixed by the latest action version. Recent issues about this problem were found on 1463 and 1425 with no definitive solution.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the dependencies Pull requests that update a dependency file label Jul 1, 2024
@tuliomir tuliomir requested a review from r4mmer July 1, 2024 21:12
@tuliomir tuliomir self-assigned this Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.53%. Comparing base (0b938b9) to head (7c87b7c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files          51       51           
  Lines        2151     2151           
  Branches      406      406           
=======================================
  Hits         1926     1926           
  Misses        208      208           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuliomir tuliomir merged commit f995bae into master Jul 2, 2024
8 checks passed
@tuliomir tuliomir deleted the chore/upgrade-actions branch July 2, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants