feat: add mint-tokens endpoint for p2sh wallet #312

alexruzenhack · 2023-06-22T12:56:32Z

Acceptance Criteria

add mint-tokens endpoint for p2sh wallet: /wallet/p2sh/tx-proposal/mint-tokens

Security Checklist

Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

Closes: #302

src/controllers/wallet/p2sh/tx-proposal.controller.js

codecov · 2023-06-22T13:14:04Z

Codecov Report

❗ No coverage uploaded for pull request base (feat/multisig-for-bridge@d9d8a82). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8d12182 differs from pull request most recent head 36be128. Consider uploading reports for the commit 36be128 to get more accurate results

@@                     Coverage Diff                     @@
##             feat/multisig-for-bridge     #312   +/-   ##
===========================================================
  Coverage                            ?   87.17%           
===========================================================
  Files                               ?       35           
  Lines                               ?     1372           
  Branches                            ?      276           
===========================================================
  Hits                                ?     1196           
  Misses                              ?      155           
  Partials                            ?       21

src/controllers/wallet/p2sh/tx-proposal.controller.js

+    }
+
+    const mintTokenTransaction = await req.wallet.prepareMintTokensData(
+      token,


__tests__/__fixtures__/http-fixtures.js

__tests__/mint-tokens.test.js

src/controllers/wallet/p2sh/tx-proposal.controller.js

src/api-docs.js

pedroferreira1 · 2023-07-11T01:09:52Z

package-lock.json

@@ -1,6 +1,6 @@
 {
  "name": "hathor-wallet-headless",
-  "version": "0.22.0-rc1",
+  "version": "0.22.0-rc2",


Why are you changing this? Shouldn't you change the lib version?

Fixed with rebase.

See:

hathor-wallet-headless/package-lock.json

Line 3 in 5b82047

"version": "0.22.0-rc3",

pedroferreira1 · 2023-07-11T01:10:01Z

package.json

@@ -1,6 +1,6 @@
 {
  "name": "hathor-wallet-headless",
-  "version": "0.22.0-rc1",
+  "version": "0.22.0-rc2",


Why are you changing this?

Fixed with rebase.

See:

hathor-wallet-headless/package-lock.json

Line 3 in 5b82047

"version": "0.22.0-rc3",

pedroferreira1 · 2023-07-11T01:10:11Z

src/api-docs.js

@@ -6,7 +6,7 @@ const apiDoc = {
  info: {
    title: 'Headless Hathor Wallet API',
    description: 'This wallet is fully controlled through an HTTP API.',
-    version: '0.22.0-rc1',
+    version: '0.22.0-rc3',


Why change this?

Fixed with rebase.

See:

hathor-wallet-headless/src/api-docs.js

Line 9 in 5b82047

version: '0.22.0-rc3',

pedroferreira1 · 2023-07-11T01:12:43Z

src/api-docs.js

+                  },
+                  address: {
+                    type: 'string',
+                    description: 'Optional destination address of the minted tokens.'


This is not optional, it's in the required array

No. It is optional. I changed the required definition.

See:

hathor-wallet-headless/src/api-docs.js

Line 1314 in 5b82047

required: ['token', 'amount'],

pedroferreira1 · 2023-07-11T01:13:03Z

src/api-docs.js

+              'application/json': {
+                examples: {
+                  error: {
+                    summary: 'Insuficient amount of tokens',


Suggested change

summary: 'Insuficient amount of tokens',

summary: 'Insufficient amount of tokens',

See:

hathor-wallet-headless/src/api-docs.js

Line 1362 in 5b82047

summary: 'Insufficient amount of tokens',

pedroferreira1 · 2023-07-11T01:14:36Z

src/routes/wallet/p2sh/tx-proposal.routes.js

+  '/mint-tokens',
+  body('token').isString().notEmpty(),
+  body('amount').isInt({ min: 1 }).toInt(),
+  body('address').isString().notEmpty().optional(),


Is it optional? The api docs description says it isn't.

But if the idea is to copy what we have in the current mint-tokens api, then it should be optional and the api docs must be fixed (the current mint tokens api docs as well).

It was fixed in the api docs.

See comment: #312 (comment)

alexruzenhack requested a review from pedroferreira1 as a code owner June 22, 2023 12:56

alexruzenhack requested a review from r4mmer June 22, 2023 12:56

alexruzenhack self-assigned this Jun 22, 2023

alexruzenhack added this to the Merge MultiSig for bridge milestone Jun 22, 2023

github-advanced-security bot found potential problems Jun 22, 2023

View reviewed changes

src/controllers/wallet/p2sh/tx-proposal.controller.js Fixed Show fixed Hide fixed

src/controllers/wallet/p2sh/tx-proposal.controller.js Fixed Show fixed Hide fixed

alexruzenhack force-pushed the feat/create-mint-endpoint branch 2 times, most recently from 0c8fc2e to cdc0a2d Compare June 22, 2023 20:40

github-advanced-security bot found potential problems Jun 22, 2023

View reviewed changes

alexruzenhack mentioned this pull request Jun 27, 2023

test: add e2e tests to multisig extension endpoints #317

Merged

1 task

alexruzenhack marked this pull request as draft July 4, 2023 13:55

alexruzenhack force-pushed the feat/create-mint-endpoint branch from 395b058 to 630d666 Compare July 4, 2023 14:07

r4mmer reviewed Jul 4, 2023

View reviewed changes

__tests__/__fixtures__/http-fixtures.js Outdated Show resolved Hide resolved

__tests__/mint-tokens.test.js Outdated Show resolved Hide resolved

src/controllers/wallet/p2sh/tx-proposal.controller.js Outdated Show resolved Hide resolved

alexruzenhack force-pushed the feat/create-mint-endpoint branch from be0cb18 to 651c12e Compare July 7, 2023 19:15

alexruzenhack changed the base branch from dev to feat/multisig-for-bridge July 7, 2023 19:22

alexruzenhack marked this pull request as ready for review July 7, 2023 19:24

r4mmer reviewed Jul 7, 2023

View reviewed changes

src/api-docs.js Outdated Show resolved Hide resolved

alexruzenhack force-pushed the feat/create-mint-endpoint branch from ca83e45 to 6ce6199 Compare July 7, 2023 20:11

r4mmer approved these changes Jul 7, 2023

View reviewed changes

pedroferreira1 reviewed Jul 11, 2023

View reviewed changes

alexruzenhack force-pushed the feat/multisig-for-bridge branch from ca283b1 to d9d8a82 Compare July 12, 2023 17:10

alexruzenhack force-pushed the feat/create-mint-endpoint branch from 6ce6199 to 36be128 Compare July 12, 2023 17:11

alexruzenhack force-pushed the feat/multisig-for-bridge branch from d9d8a82 to a069090 Compare July 12, 2023 17:33

alexruzenhack merged commit 36be128 into feat/multisig-for-bridge Jul 12, 2023
2 checks passed

alexruzenhack force-pushed the feat/multisig-for-bridge branch from a069090 to 5b82047 Compare July 12, 2023 17:43

alexruzenhack deleted the feat/create-mint-endpoint branch July 12, 2023 18:03

alexruzenhack restored the feat/create-mint-endpoint branch July 14, 2023 17:08

alexruzenhack deleted the feat/create-mint-endpoint branch July 14, 2023 17:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add mint-tokens endpoint for p2sh wallet #312

feat: add mint-tokens endpoint for p2sh wallet #312

alexruzenhack commented Jun 22, 2023 •

edited

Loading

codecov bot commented Jun 22, 2023 •

edited

Loading

pedroferreira1 Jul 11, 2023

alexruzenhack Jul 12, 2023

alexruzenhack Jul 12, 2023 •

edited

Loading

pedroferreira1 Jul 11, 2023

alexruzenhack Jul 12, 2023

alexruzenhack Jul 12, 2023

pedroferreira1 Jul 11, 2023

alexruzenhack Jul 12, 2023

alexruzenhack Jul 12, 2023 •

edited

Loading

pedroferreira1 Jul 11, 2023

alexruzenhack Jul 12, 2023

alexruzenhack Jul 12, 2023

pedroferreira1 Jul 11, 2023

alexruzenhack Jul 12, 2023

alexruzenhack Jul 12, 2023

pedroferreira1 Jul 11, 2023

alexruzenhack Jul 12, 2023

alexruzenhack Jul 12, 2023

	summary: 'Insuficient amount of tokens',
	summary: 'Insufficient amount of tokens',

feat: add mint-tokens endpoint for p2sh wallet #312

feat: add mint-tokens endpoint for p2sh wallet #312

Conversation

alexruzenhack commented Jun 22, 2023 • edited Loading

Acceptance Criteria

Security Checklist

codecov bot commented Jun 22, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexruzenhack Jul 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexruzenhack Jul 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexruzenhack commented Jun 22, 2023 •

edited

Loading

codecov bot commented Jun 22, 2023 •

edited

Loading

alexruzenhack Jul 12, 2023 •

edited

Loading

alexruzenhack Jul 12, 2023 •

edited

Loading