This repository has been archived by the owner on Mar 29, 2022. It is now read-only.
Introduce editorconfig #694
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattIPv4
suggested changes
Oct 19, 2020
.editorconfig
Outdated
Comment on lines
13
to
12
| [{*.{rb,erb,js,coffee,json,yml,css,scss,sh,markdown,md,html}] | ||
| indent_size = 2 |
There was a problem hiding this comment.
This seems like an odd way to set the indent. Why not set indent_size = 2 for everything, and then set a different indent size for anything that doesn't fit that?
There was a problem hiding this comment.
Makes sense. I will update accordingly.
the-spectator
force-pushed
the
introduce_editor_config
branch
3 times, most recently
from
91ae00d
to
5167e3c
Compare
the-spectator
force-pushed
the
introduce_editor_config
branch
from
5167e3c
to
ce63a4d
Compare
|
@MattIPv4 I have updated according to your review and added |
the-spectator
commented
Oct 19, 2020
| @@ -19,3 +19,5 @@ jobs: | |||
| gem install bundler dotenv | |||
| bundle install --jobs 4 --retry 3 | |||
| bundle exec rubocop | |||
| - name: Enforce EditorConfig | |||
| uses: zbeekman/EditorConfig-Action@28b76e718c351dd35b22c8f7216192bb9de5c21b | |||
There was a problem hiding this comment.
Had to use SHA because of npm audit issue in action zbeekman/EditorConfig-Action#35
MattIPv4
reviewed
Oct 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to partially address #623 by adding
.editorconfig. Editorconfig helps to maintain consistent file formatting across various editors and IDEs.Resource
Test process
Requirements to merge