This repository has been archived by the owner on Mar 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 145
Gifted shirt coupons #438
Open
fridaland
wants to merge
58
commits into
Hacktoberfest:master
Choose a base branch
from
fridaland:gifted-shirt-coupons
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gifted shirt coupons #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: John Britton <[email protected]>
Co-Authored-By: John Britton <[email protected]>
Co-Authored-By: John Britton <[email protected]>
Co-Authored-By: John Britton <[email protected]>
Co-Authored-By: John Britton <[email protected]>
This will need to be rebased against master once #437 is merged. |
fridaland
force-pushed
the
gifted-shirt-coupons
branch
from
November 14, 2019 23:24
abfa362
to
6fbe884
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to gift shirts to incompleted users
In #437 we added the ability to gift
sticker_coupons
. This pull request will allow users to receive "gifted" t-shirt coupons as well.Test process
Currently, we only allow
completed
users to receive shirt coupons.Changes necessary:
CouponService
CouponService
to allow incompleted users to receive shirt coupons.coupon_service_specs
are no longer pendinguser_spec
for there are shirt coupons availableRequirements to merge