This repository has been archived by the owner on Mar 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 145
Handle GitHub errors #431
Open
jhaff
wants to merge
26
commits into
Hacktoberfest:master
Choose a base branch
from
jhaff:handle-github-errors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Handle GitHub errors #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fest into handle-github-errors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from #412
Description
Fixes #409
This PR consolidates error handling logic for the case when a user's account is suspended(
Octokit::AccountSuspended
) and when a user's account is missing from Github (GithubPullRequestService::UserNotFoundOnGithubError
). This sits in a new service object which gets passed a user and a block,GithubErrorHandler
.For both of these errors, we handle by deactivating the user, putting them in the
inactive
state (a new state on the state machine specifically for these users no longer accounted for in GitHub) and deleting their associatedUserStat
, if they have one.Test process
inactive
stateUserStat
is deleted, if they had oneRequirements to merge