Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'fp32' option for softmax_mode in FusedFSDPA #113

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add 'fp32' option for softmax_mode in FusedFSDPA #113

wants to merge 2 commits into from

Conversation

yangulei
Copy link

The 'fp32' option for softmax_mode in FusedFSDPA is enabled since Synapse v1.20.0.

@yangulei
Copy link
Author

Update:
set valid_seq_lengths=None for softmax_mode='fp32' as we observed accuracy issue on Qwen2-1.5B-Instruct and Deepseek-R1 for softmax_mod='fp32' and setting valid_seq_lengths=None could fix it.

michalkuligowski
michalkuligowski reviewed Mar 24, 2025
View reviewed changes
Copy link
Contributor

@michalkuligowski michalkuligowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yangulei Is this still valid, given your last comment?

@yangulei
Copy link
Author

@yangulei Is this still valid, given your last comment?

Yes, no more accuracy issue observed after setting valid_seq_lengths=None for softmax_mod='fp32' case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkuligowski michalkuligowski michalkuligowski approved these changes

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@madamczykhabana madamczykhabana Awaiting requested review from madamczykhabana madamczykhabana is a code owner

@mgawarkiewicz mgawarkiewicz Awaiting requested review from mgawarkiewicz mgawarkiewicz is a code owner

@tzielinski-habana tzielinski-habana Awaiting requested review from tzielinski-habana tzielinski-habana is a code owner

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangulei @michalkuligowski