[FIX] fp8 gc compile error #110
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maktukmak
requested review from
kzawora-intel,
madamczykhabana,
michalkuligowski,
mgawarkiewicz,
tzielinski-habana and
afierka-intel
as code owners
| @@ -413,6 +413,7 @@ def scaled_fp8_quant( | |||
| Tuple[torch.Tensor, torch.Tensor]: The output tensor in FP8 and | |||
| scaling factor. | |||
| """ | |||
| htorch.core.mark_step() | |||
There was a problem hiding this comment.
Do we know where this cycle comes from? Adding mark step might just hide the issue, lets talk offline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FP8 static quantized models with AutoFP8 give graph compiler errors during inference with vLLM. The error message was 'Invalid graph—a cycle was found in the graph. ' This PR fixes the issue.