Make lazy mode autodetection more robust #921
Open
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzawora-intel
requested review from
madamczykhabana,
michalkuligowski,
mgawarkiewicz,
vivekgoe and
afierka-intel
as code owners
| is_lazy = htorch.utils.internal.is_lazy{} | ||
| if is_lazy: | ||
| torch._dynamo.config.disable = True | ||
| env_update_dict['PT_HPU_ENABLE_LAZY_COLLECTIVES'] = 'true' |
There was a problem hiding this comment.
Do we really need to clean this up? I'm assuming PT_HPU_ENABLE_LAZY_COLLECTIVES only affects lazy and is ignored in other cases. If we skip cleanup we could end up with something as simple as:
os.environ['PT_HPU_ENABLE_LAZY_COLLECTIVES'] = 'true'
import habana_frameworks.torch as htorch
if htorch.utils.internal.is_lazy:
torch._dynamo.config.disable = True
vllm/plugins/__init__.py
Outdated
| is_lazy = lazy_mode_env_var == '1' | ||
| if lazy_mode_env_var is None: | ||
| import habana_frameworks.torch as htorch | ||
| is_lazy = htorch.utils.internal.is_lazy{} |
There was a problem hiding this comment.
what is this syntax? Is it a typo?
There was a problem hiding this comment.
yeah, i should probably get a new pair of glasses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.