Fix spec decoding warmup #906
Open
+44
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangw1234
requested review from
kzawora-intel,
madamczykhabana,
michalkuligowski,
mgawarkiewicz,
vivekgoe and
afierka-intel
as code owners
yangw1234
commented
Mar 13, 2025
| @@ -258,3 +258,14 @@ def __init__( | |||
|
|
|||
| def __getattr__(self, attr): | |||
| return getattr(self.model_runner, attr) | |||
|
|
|||
| def __setattr__(self, name, value): | |||
There was a problem hiding this comment.
@michalkuligowski The purpose of this class is to imitate the behavior of a regular model runner and delegate all methods, attributes access to the self.model_runner.
Adding __setattr__ here is to solve the problem when setting a attr in base and use it later. E.g.
model_wrapper = ModelRunnerWrapperBase(hpu_model_runner)
model_wrapper.mem_margin = some_value
model_wrapper.mem_marginmodel_wrapper.mem_margin = some_value this line will set a attr to the base class if we do not have __setattr__, but when we want to get the value by model_wrapper.mem_margin, the base class will delegate the access to self.model_runner which does not have this property and causing an error.
|
@xuechendi @michalkuligowski please help review |
|
The failed tests exists in other PRs and are not related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mem_marginhere will not be setting in the delegated innermodel_runnerproposer.determine_num_available_blocks()is not called inspec_decoder_workerand is not implemented by other proposers.previous_hidden_statesto the warmup inputs to relevant proposer model.