forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick of "Selective merged prefill #643" #893
Open
kamil-kaczor
wants to merge
13
commits into
habana_main
Choose a base branch
from
cherrypick_merged_prefill
base: habana_main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2afb048
Cherry-pick: "Selective merged prefill (#643)"
xuechendi e96af62
Fix indent, linter, ruff
kamil-kaczor f9faa8a
Fix yapf, ruff
kamil-kaczor 4f64e8a
Cherry-pick: "Selective merged prefill (#643)"
xuechendi d51eb62
Remove changes to benchmark throughput
kamil-kaczor d6c2f02
Remove mypy WA from delayed
kamil-kaczor 16bca32
Fix mypy in hpu_attn
kamil-kaczor 3e71daf
Remove second class of mergedprefill
kamil-kaczor 254ea06
Fix missing enable_kv_scales_calculation
kamil-kaczor 8fcfea5
Fix mypy in model_runner
kamil-kaczor 33b0843
Fix linter
kamil-kaczor 87c4e7e
yapf fix
kamil-kaczor 6b1cfae
Merge branch 'habana_main' into cherrypick_merged_prefill
kamil-kaczor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in hpu-extension/ops.py where all our attn implementations are. What's the difference between this and other implementations? Is it only because is_causal is False?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, duplicate this func to use 'is_causal' as False.