[Issue #2184] Tidy up python and docker usage in analytics #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
requested review from
coilysiren,
widal001 and
AlexanderStephensonUSDS
as code owners
acouch
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2184
Time to review: 3 mins
Changes proposed
Fixed our Python version to 3.12 (dockerfile and pyproject.toml)
Removed usage of
docker-composecommand fordocker composeRemoved version from docker-compose file (prints a warning - no longer used)
Context for reviewers
Similar changes have been made recently to the API. Was updating dependencies in the folder earlier and realized these should also happen for analytics and are pretty minimal.
The Python version change doesn't change what version of Python we use, but I've found in past years when new versions of Python come out, a lot of dependencies temporarily break until they've had a chance to build in upstream repositories. This change just makes it so we can manually test that upgrade and take care of it once things are less chaotic (note Python releases occur in October).
docker-composeas a command has been deprecated for years and for the most part wasn't being used in the makefile, but there was still one left. I actually can't run it anymore on a newish version of docker.The version field is deprecated and unused in the docker-compose file and just causes a warning of
WARN[0000] /Users/michaelchouinard/workspace/grants-equity/analytics/docker-compose.yml: the attributeversionis obsolete, it will be ignored, please remove it to avoid potential confusionto be printed, so removing that line fixes it.