Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Each category added with icons. List can now be filtered by category. Checkbox are shifted to div instead for better UX. #180

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

aetherfaye1009
Copy link

Description

  • Category Icons: Added icons for each category in the todo list for improved visual representation.

  • Category Filtering: Implemented category filtering, allowing users to filter the todo list by the selected category.
    The category filter now works seamlessly alongside the status filter, enabling users to apply both filters simultaneously.

  • Checkbox Functionality: Updated the checkbox functionality to trigger the toggleComplete function when clicking anywhere on the task div, rather than just the checkbox itself. This change enhances user experience by making it easier to mark tasks as complete.

  • Edit Functionality: The planned enhancements for the edit feature were not implemented. Upon review, it was determined that the proposed changes would likely confuse users even further, disrupting the workflow and creating a less cohesive experience. Therefore, this task was not proceeded with to maintain clarity and usability within the application.

Summary:
These changes enhance the overall usability and visual appeal of the todo list application. Users can now easily filter tasks by category and status, while the improved checkbox interaction streamlines task management.

Fixes #112

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so that they can be reproduced.

  • Verified that refreshing the page sets the default category filter to "Today" and filter are applied correctly.
  • Tested each category filter alongside the status filter to ensure the tasks displayed correctly reflect the selected filters.
  • Checked that clicking on the entire task div toggles the completion status of the checkbox accurately.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Cheng Wang added 3 commits October 14, 2024 20:43
…enhancements : Clicking on the task will mark it as completed or not completed without needing to click directly on the checkbox.
@aetherfaye1009
Copy link
Author

aetherfaye1009 commented Oct 14, 2024

image
image
image
image
image

@aetherfaye1009
Copy link
Author

Please assign me the hacktoberfest tag once you are okay.

@aetherfaye1009
Copy link
Author

I accidentally merged, so I just revert commits

@Anshgrover23
Copy link
Collaborator

@aetherfaye1009 kindly resolve conflicts.

@aetherfaye1009
Copy link
Author

@Anshgrover23 done, please check again

Copy link
Collaborator

@Anshgrover23 Anshgrover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aetherfaye1009 what is this? remove this from main landing page.

image

@aetherfaye1009
Copy link
Author

image
image
image
image

@aetherfaye1009
Copy link
Author

Thanks for reviewing the recent changes. If possible, could we also consider a review of the CSS in the repository? There appear to be some overlapping class names and styles, which might lead to UI inconsistencies and make the codebase a bit harder to maintain. Let me know if anything.

@Anshgrover23
Copy link
Collaborator

@aetherfaye1009 yes, you are free to make a review on CSS inconsistencies. Also, kindly resolve conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add icons for each category and list can be filtered by category
2 participants