Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use items-changed event ILO MutationObserver for markers (issue 299) #303

Closed
wants to merge 1 commit into from

Conversation

mlisook
Copy link
Contributor

@mlisook mlisook commented Jun 17, 2016

… issue #299 ...

The MutationObserver works in shady dom but not in shadow dom because it is observing a shadow dom element (iron-selector.#selector). Mutation events cannot pierce the shadow dom (there is even a test for this in chromium - MutationObserver / shadow-dom.html ).

Instead, we can use the iron-selector items property and a change listener.
This also allows us to include the markers-add-remove.html test in both shadow (where it previously failed) and shady.

…issue 299)

The MutationObserver works in shady dom but not in shadow dom because it is observing a shadow dom element (iron-selector.#selector). Mutation events cannot pierce the shadow dom.
Instead, we can use the iron-selector items property and a change listener.
This also allows us to the include markers-add-remove.html test in both shadow (where it previously failed) and shady.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mlisook
Copy link
Contributor Author

mlisook commented Jun 17, 2016

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@mlisook
Copy link
Contributor Author

mlisook commented Jun 17, 2016

I signed it!

@mlisook mlisook closed this Jun 17, 2016
@mlisook mlisook deleted the issue299fix branch June 18, 2016 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants