fix: remove unnecessary basename #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birunts
reviewed
Dec 17, 2024
|
Just hit this as well. It would be great to get this merged. Thanks for the fix @jjmaestro! |
mattyclarkson
approved these changes
Jan 7, 2025
thesayyn
approved these changes
Jan 20, 2025
|
I don't know why the CI is not kicking in. @jjmaestro do you mind force pushing so the CI runs? |
Fixes GoogleContainerTools#141 In GoogleContainerTools#99 I added a dependency to basename when it's not really needed. Credit and thanks to @birunts for finding the issue and providing the solution!
|
@thesayyn after the forced push I think the CI workflows need approval to run |
|
@thesayyn this one's ready to merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141
In #99 I added a dependency to basename when it's not really needed.
Credit and thanks to @birunts for finding the issue and providing the solution!