Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up updates triggered between render & useEffect #57

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

raibima
Copy link

@raibima raibima commented Jun 17, 2020

useEffect isn't called synchronously after render. There's a slight chance a change event is dispatched after our initial read but before we register our listener in useEffect.

Timeline:

useState(initialValue) --- "change" event triggered --- useEffect (subscribe)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@raibima
Copy link
Author

raibima commented Jun 17, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@raibima raibima marked this pull request as ready for review June 17, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants