Refactor code.yml Action #749
Conversation
We should just check new sets on JSON.yml as it prints errors for the PR author to fix, but we should ensure this job covers the full file since it runs on master too.
arichiv
requested review from
cfredric,
krgovind,
miketaylr and
sjledoux
as code owners
|
This makes it possible for unrelated timeouts/failures to block a PR submission, since PRs are validating the well-known files of the full set, right? I think it'd be better to make the PR workflows only validate things that are related to the PR itself. |
|
We're also going to have to enhance the script itself to handle the legacy well-known file location, since the older set entries don't serve from related-website-set.json. |
arichiv
changed the title
|
The RWS JSON was successfully validated! |
|
I don't think that the new workflow this is adding, |
|
I added #750 to resolve errors in old sets. I think it's worth checking them so that we know if they drift out of compliance for some reason, but exemptions may have to be added for some legacy entries. |
The prior code.yml action was validating no RWS sets and running tests, and it did this on PRs, main, and CRON.
We want to validate all sets on main/CRON but not block PRs.
code.yml now just runs tests on PRs and main.
json.yml was renamed json_pr.yml with no changes.
json_main.yml was added, and validates all RWS sets on main and CRON.